[PATCH] D42424: [InstCombine] Allow common type conversions to i8/i16

[Dave Green via Phabricator via llvm-commits]

dmgreen updated this revision to Diff 131592.
dmgreen added a subscriber: kparzysz.
dmgreen added a comment.

Thanks for the info. Unfortunately it looks like I was previously building without all backends (or an intervening commit has changed things?), and a test in Hexagon (CodeGen/Hexagon/loop-idiom/pmpy-mod.ll) is failing due to this. It looks like the code entering into the hexagon loop recogniser is shorter, but is no longer recognised and transformed to a single intrinsic.

Does anyone know if there a more sensible way to do this? Perhaps just for the ARM/AArch64 backends, not for all targets, no matter how odd they are. Or do we think this is the best way to do things?


https://reviews.llvm.org/D42424

Files:
  lib/Transforms/InstCombine/InstructionCombining.cpp
  test/Transforms/InstCombine/2010-11-01-lshr-mask.ll
  test/Transforms/InstCombine/and-narrow.ll
  test/Transforms/InstCombine/select-bitext.ll
  test/Transforms/InstCombine/should-change-type.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42424.131592.patch
Type: text/x-patch
Size: 16065 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180126/0473d9a4/attachment.bin>