[PATCH] D42566: [InstCombine] Preserve debug values for eliminable casts

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCasts.cpp:275
+      findDbgUsers(CSrcDbgInsts, CSrc);
+      if (CSrcDbgInsts.size()) {
+        DIBuilder DIB(*CI.getModule());
----------------
Out of curiosity: why check `size()` and not `empty()`? Although irrelevant, the STL only guarantees that `empty()` is `O(1)`, but it's why it caught my eye here. :-) 


https://reviews.llvm.org/D42566