[PATCH] D42220: libcxx: Use vcruntime declarations for typeinfo on Windows.

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 17:07:22 PST 2018


compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

I think that this is reasonable to unblock the use of libc++ with and without vcruntime headers.  The one thing that I wish was slightly cleaner is not your fault.



================
Comment at: libcxx/src/typeinfo.cpp:53
+     !defined(__GLIBCXX__) && !defined(__APPLE__) &&                           \
+     !(defined(_LIBCPP_ABI_MICROSOFT) && !defined(_LIBCPP_NO_VCRUNTIME))) ||   \
     defined(_LIBCPP_BUILDING_HAS_NO_ABI_LIBRARY)
----------------
I wish that there was a reasonable way to split this logic up.


https://reviews.llvm.org/D42220





More information about the llvm-commits mailing list