[PATCH] D42021: [DWARF] v5 implementation of string offsets tables - producer side

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

Sounds alright - thanks (:



================
Comment at: test/DebugInfo/Generic/string-offsets-form.ll:20-22
+; CHECK:     DW_TAG_enumeration_type
+; CHECK-NOT: DW_TAG
+; CHECK:     DW_AT_name DW_FORM_strx2
----------------
You can probably just check the debug_info and skip checking the abbrev here (since you are checking the form kind in the debug_info).

Though how do you know the first enumeration_type would have a strx2? Actually I'm a bit surprised the enumeration_type's name would be strx2 (would've guessed its string would be computed early and before all the enumerators?)?


https://reviews.llvm.org/D42021