[PATCH] D42551: [Debug] Add dbg.value intrinsics for PHIs created during LCSSA.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.

Thanks, this LGTM. Patches are generally easier to review when you separate out the NFC parts (moving the function to local) into a separate commit.



================
Comment at: lib/Transforms/Utils/LCSSA.cpp:226
+        NeedDbgValues.push_back(PN);
+    insertDebugValuesForPHIs(InstBB, NeedDbgValues);
     Changed = true;
----------------
Is this the one line that is not NFC in this patch?


https://reviews.llvm.org/D42551