[PATCH] D41771: [mips] Include EVA instructions in the Std2MicroMips mapping tables

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 02:43:08 PST 2018


sdardis added a comment.

Yes, adding them manually is fine. We haven't implemented support for _builtin_prefetch or _builtin_mips_cache, so that's the only way to test them.



================
Comment at: test/CodeGen/Mips/micromips-eva.mir:4-7
+  ; ModuleID = 'example.ll'
+  source_filename = "example.cpp"
+  target datalayout = "E-m:m-p:32:32-i8:8:32-i16:16:32-i64:64-n32-S64"
+  target triple = "mips--linux-gnu"
----------------
This can be removed from the test case.


================
Comment at: test/CodeGen/Mips/micromips-eva.mir:55-61
+  attributes #0 = { noinline nounwind optnone "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="mips32r3" "target-features"="+mips32r2,-noabicalls" "unsafe-fp-math"="false" "use-soft-float"="false" }
+  
+  !llvm.module.flags = !{!0}
+  !llvm.ident = !{!1}
+  
+  !0 = !{i32 1, !"wchar_size", i32 4}
+  !1 = !{!"clang version 7.0.0 (https://github.com/llvm-mirror/clang.git ee91cd8cc8f7556097251e80046562a42e140483) (https://github.com/llvm-mirror/llvm.git 3bd60530e3407da61dfe439ea2947dc0932d753e)"}
----------------
All this and the "#0"s from the function definitions can be removed from the test case.


https://reviews.llvm.org/D41771





More information about the llvm-commits mailing list