[PATCH] D42390: msan: Pass --disable-new-dtags for tests

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 02:25:41 PST 2018


Hahnfeld added a comment.

In https://reviews.llvm.org/D42390#987540, @hintonda wrote:

> I'll let @eugenis speak for himself, but in general LD_LIBRARY_PATH is not a good idea.  A quick google search will provide a bunch of links to blogs and articles that make a much stronger case than I can.


Okay, rethinking about this, we probably can't get rid of it in our environment because we use the modules system (http://modules.sourceforge.net/) which heavily relies on modifying environment variables.

In general, would patches be acceptable (maybe in a different form) that solves this kind "problem"?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42390





More information about the llvm-commits mailing list