[PATCH] D42501: [dsymutil] Generate Apple accelerator tables

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.

In https://reviews.llvm.org/D42501#987033, @aprantl wrote:

> Looks mostly good, the test coverage could probably be a little better.


Thanks for having a look, Adrian! I'm planning on extending the existing test with the other `.apple_*` sections. A bunch more tests will be added when upstreaming the `-update` functionality as well, but that's for another diff.



================
Comment at: tools/dsymutil/CMakeLists.txt:4
   AsmPrinter
+  BinaryFormat
   DebugInfoDWARF
----------------
aprantl wrote:
> What's the dependency that makes this necessary?
The call to `dwarf::djbHash()`


================
Comment at: tools/dsymutil/DwarfLinker.cpp:1311
     Asm->EmitInt32(Name.Die->getOffset());
-    Asm->OutStreamer->EmitBytes(
-        StringRef(Name.Name.data(), Name.Name.size() + 1));
+    Asm->OutStreamer->EmitBytes(StringRef(Name.Name.getString().data(),
+                                          Name.Name.getString().size() + 1));
----------------
aprantl wrote:
> The + 1 is for a \NUL? And it's guaranteed to exist?
I'll double check!


Repository:
  rL LLVM

https://reviews.llvm.org/D42501