[PATCH] D42450: [utils] Convert update_{llc_, }test_checks.py to Python 3

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 13:10:22 PST 2018


bogner added a comment.

In https://reviews.llvm.org/D42450#985851, @MaskRay wrote:

> Thanks for your attention... I'd like to see llvm moving away from legacy python2.7


Changes to make these scripts work with both 2.7 and 3 are probably a more practical approach in the short term. I suspect there will still be a fair amount of resistance to dropping python2.7 support in LLVM for a bit yet.

> I intent to add something called update_clang_test_checks.py (.cc -> .ll or .cc -> .s) and find these scripts really should be combined..

As Sanjay mentioned, this has been attempted in the past. It may make more sense to break out some of the common parts into a library and use it in both, as the scripts do have slightly different needs. I've been thinking about how to approach this, and suspect some of the ideas implemented in update_mir_test_checks will help.


Repository:
  rL LLVM

https://reviews.llvm.org/D42450





More information about the llvm-commits mailing list