[PATCH] D42496: [CMake] Fix Bug Report URL

Colden Cullen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 11:54:00 PST 2018


colden added a comment.

In https://reviews.llvm.org/D42496#986872, @smeenai wrote:

> LGTM.


Thanks for reviewing this for me!

> For future reference, you should upload diffs with more context (`-U9999`, or just use arcanist). This is trivial so it doesn't matter that much. It's also a good idea to add some reviewers explicitly, otherwise it's easy for things to slip through on the mailing list.

I did use arcanist, is there a special config option I have to set or something? I'm on Windows too, so maybe that's it? I'll dig around the internet to see if I can fix it for next time.
Good call on the reviewers, I usually do a blame to see who to send these to, but it just slipped my mind this time :)

> Do you have commit access?

I do not. I'd really appreciate it if you'd submit this for me!

Thanks again!


Repository:
  rL LLVM

https://reviews.llvm.org/D42496





More information about the llvm-commits mailing list