[PATCH] D42297: [DebugInfo] Basic .debug_names dumping support

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 03:39:21 PST 2018


JDevlieghere added a comment.

In https://reviews.llvm.org/D42297#986174, @labath wrote:

> I was hoping to leave that for a separate patch.


Doing this in a separate patch sounds like the right thing to do.

> The main reason the ValueIterator class cannot be used out-of-the-box is because it assumes the accelerator table is homogeneous, but in the dwarf5 case, each abbreviation can describe a different set of index attributes. So we will need to come up with a more generic iterator for the dwarf tables (and that one can then be used for the apple tables as well).  (And even the tiny bit of parsing that happens in the iterator (`Next()` function) is incorrect for dwarf5).

Alright, I have some questions but maybe it's better so save this discussion for the other patch :-)


Repository:
  rL LLVM

https://reviews.llvm.org/D42297





More information about the llvm-commits mailing list