[PATCH] D42082: Add DWARF for discriminated unions

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 16:47:59 PST 2018


probinson added a comment.

In https://reviews.llvm.org/D42082#982469, @tromey wrote:

> FWIW, I had forgotten about this, but when I was first writing this patch I did find a dwarf-discuss thread about the discriminant placement issue: http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2006-August/001710.html


Huh.  Well, if *nobody* is following the spec, it becomes expedient to fix the spec. :-)  Functionally I don't think it makes any real difference where the discriminant's DIE is, because the variant_part has a reference to it anyway.


Repository:
  rL LLVM

https://reviews.llvm.org/D42082





More information about the llvm-commits mailing list