[PATCH] D42378: [X86][SSE] Avoid calls to combineX86ShufflesRecursively that can't combine to target shuffles (PR32037)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 15:09:23 PST 2018


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - see inline comment for a nit.



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:29403
+  // the remaining recursion depth.
+  if (Ops.size() < (unsigned)(MaxRecursionDepth - Depth)) {
+    for (int i = 0, e = Ops.size(); i < e; ++i)
----------------
Change Depth and MaxRecursionDepth to unsigned instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D42378





More information about the llvm-commits mailing list