[PATCH] D42441: IRGen: On MSVCRT platforms, implement __builtin_wmemcmp using memcmp.

Adrian McCarthy via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 14:04:28 PST 2018


Oh, I see.  Thanks for clarifying!

On Tue, Jan 23, 2018 at 1:55 PM, Peter Collingbourne <peter at pcc.me.uk>
wrote:

> Yes, but wmemcmp is defined with an inline implementation in the header,
> and the .lib file does not contain a definition for it.
>
> Peter
>
> On Tue, Jan 23, 2018 at 1:50 PM, Adrian McCarthy <amccarth at google.com>
> wrote:
>
>> MSVC RT does have wmemcmp, but it's in a different header file:
>>
>> https://msdn.microsoft.com/en-us/library/zyaebf12.aspx
>>
>> On Tue, Jan 23, 2018 at 1:43 PM, Peter Collingbourne via Phabricator via
>> llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>>> pcc planned changes to this revision.
>>> pcc added a comment.
>>>
>>> Oops, it does indeed. I guess we'll need to emit an inline
>>> implementation.
>>>
>>>
>>> https://reviews.llvm.org/D42441
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>>
>
>
> --
> --
> Peter
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180123/3e5799b4/attachment.html>


More information about the llvm-commits mailing list