[PATCH] D42400: [PPC] Avoid incorrect fp-i128-fp lowering.

[Tim Shen via Phabricator via llvm-commits]

timshen added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/fp-int128-fp-combine.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -O0 -mtriple=powerpc64le-unknown-linux-gnu < %s | FileCheck %s
----------------
jtony wrote:
> Can we explicitly put CHECK-NOT for the `xscvdpsxds +
> xscvsxdsp` instructions we were generating before in this test case to avoid regression? 
> Other than that, the patch LGTM.
IIRC update_llc_test_checks.py will remove old CHECKs and re-insert its own CHECKs.

I think with the current line-by-line CHECK-NEXTs, it effectively prevents xscvdpsxds and xscvsxdsp from creeping in.


https://reviews.llvm.org/D42400