[PATCH] D42433: [WebAssembly] Update wasm target triple now that its the default

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 11:47:05 PST 2018


sunfish added a comment.

The codegen tests in LLVM all still use all 4 parts, and I tend to prefer that, because it avoids problems where tests pass on some hosts and fail on others due to LLVM completing the triple by auto-detecting things from the host it's running on. This may not affect wasm today, but it's a habit I'm in from other LLVM work. However, if there are reasons to omit some of the parts in the lld tests, I'm not opposed either.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42433





More information about the llvm-commits mailing list