[PATCH] D42212: [ThinLTO] Add call edges' relative block frequency to per-module summary.

[Easwaran Raman via Phabricator via llvm-commits]

eraman added inline comments.


================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:63
+  uint32_t RelBlockFreq : 29;
+  const uint64_t MaxRelBlockFreq = (1 << 29) - 1;
+
----------------
tejohnson wrote:
> This shouldn't be here - it is adding overhead to every single call edge. I confirmed that with this here, the new sizeof(CalleeInfo) is 16 bytes (4 bytes for Hotness+RelBlockFreq, 4 bytes for padding to start uint64_t, 8 bytes for uint64_t). Without this defined here the sizeof(CalleeInfo) goes down to 4 bytes as expected.
Good catch. I have made this to a static constexpr and avoided the definition. Let me know if this looks okay.


Repository:
  rL LLVM

https://reviews.llvm.org/D42212