[PATCH] D41696: [DebugInfo] Emit DWARF reference for DIVariable 'count' in DISubrange

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1316
+    // I think we can assert() here that the DIE of the count variable has
+    // already been instantiated, since 'finishVariableDefinition' that
+    // creates the types for a variable is always called _after_ the DIEs
----------------
remove everything up until (and including) "since".


================
Comment at: test/DebugInfo/Generic/disubrange.ll:5
+; CHECK-DAG: DW_AT_count [DW_FORM_ref4]  (cu + {{.*}} => {[[NODE:[0-9a-zA-Zx]+]]})
+; CHECK-DAG: [[NODE]]: DW_TAG_variable [4]
+
----------------
For documentation, could you CHECK the TAG_variable first and also CHECK for its name?


https://reviews.llvm.org/D41696