[PATCH] D42374: [RFC] Add IsFixed field to ISD::ArgFlagsTy

Wei-Ren Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 05:13:13 PST 2018


chenwj added a comment.

I think this field is useful for most targets. Just a little concern about the coding style.



================
Comment at: lib/CodeGen/SelectionDAG/FastISel.cpp:976
+  unsigned i = 0;
   for (auto &Arg : CLI.getArgs()) {
     Type *FinalType = Arg.Ty;
----------------
Would changing the range-based for loop to index-based one be more consistent?


Repository:
  rL LLVM

https://reviews.llvm.org/D42374





More information about the llvm-commits mailing list