[PATCH] D41949: [RISCV] [WIP] implement li pseudo instruction

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 02:44:58 PST 2018


asb added a comment.

In https://reviews.llvm.org/D41949#980499, @niosHD wrote:

> Addresses all of Alex's comments (thank you) and integrates PseudoLI emission into CodeGen.
>
> More comments are welcome. Especially opinions about the correct location (and name) for the `emitLoadImm` method which is currently simply copied to both users.


It's not immediately obvious exactly where it should go. It looks like Mips just ended up duplicating logic. Finding somewhere for it in RISCVDesc seems like it would be reasonable. Does anyone have else have any thoughts?


https://reviews.llvm.org/D41949





More information about the llvm-commits mailing list