[PATCH] D31772: [PowerPC] Add pass to expand extra memcpy calls

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 22 20:09:35 PST 2018


sfertile added inline comments.
Herald added a subscriber: hintonda.


================
Comment at: lib/Target/PowerPC/PPCLowerMemIntrinsics.cpp:101
+      !CPUCheck(CPUAttr.getValueAsString())) {
+    return false;
+  }
----------------
hfinkel wrote:
> You should allow this check to be overridden when the user explicitly enables the transformation.  You can do this by checking `EnableMemcpyExpansionPass.getNumOccurrences() > 0 && EnableMemcpyExpansionPass`.
This pass is off by default right now, so we have to specify this at least once to turn it on.  I could add this check in the follow up patch that enables the pass by default though.


Repository:
  rL LLVM

https://reviews.llvm.org/D31772





More information about the llvm-commits mailing list