[PATCH] D42403: libcxx: Move #include_next <math.h> out of header guard in wrapper header.

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

LGTM, though I'll wait a few days before accepting in case Eric and Marshall have comments.



================
Comment at: libcxx/include/math.h:11
 
+#include_next <math.h>
+
----------------
Could you add a comment explaining why this include is outside the header guards, since that's not standard?

Also, do you think it's worth adding a test for this? It would necessarily have to be Windows-only, and we don't have a Windows libc++ buildbot right now so it wouldn't catch regressions right away, but I think it'd be helpful for the future.


https://reviews.llvm.org/D42403