[PATCH] D42311: [SyntheticCounts] Rewrite the code using only graph traits.

[Easwaran Raman via llvm-commits]

I could pass a callback to indicate whether the node is an empty node and
rewrite this code but I don't quite understand why this is so out of place
in CallGraphTraits (not in GraphTraits).

On Mon, Jan 22, 2018 at 4:01 PM, Daniel Berlin via Phabricator <
reviews at reviews.llvm.org> wrote:

> dberlin added a comment.
>
> I don't understand why you need has_function_def. It looks very much like
> a thing you should just be using a filter_iterator for or something. It
> does not look like it belongs in the graphtraits at all.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D42311
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180122/0dff6adb/attachment.html>