[PATCH] D42389: [ubsan] Add preinit initializer for ubsan

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 22 13:37:41 PST 2018


vitalybuka added a comment.

In https://reviews.llvm.org/D42389#984301, @fjricci wrote:

> > No, we need it to support configuring the runtime using setenv for the reasons described in the review of https://reviews.llvm.org/D39827.
>
> Afaik, those reasons are android app-specific. We could theoretically still use getenv() on android, since preinit arrays aren't supported there anyway.


Could you update your patch to pick getenv vs GetEnv depending on SANITIZER_CAN_USE_PREINIT_ARRAY.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42389





More information about the llvm-commits mailing list