[PATCH] D42389: [ubsan] Add preinit initializer for ubsan

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a subscriber: pcc.
vitalybuka added a comment.

It was disabled by @pcc in https://reviews.llvm.org/D39827 because of Android issues, and now https://reviews.llvm.org/D42329 disabled signal handling on Android at all, So I guess it's safe to return preinit arrays.



================
Comment at: lib/ubsan/CMakeLists.txt:14
   ubsan_init_standalone.cc
+  ubsan_preinit.cc
   ubsan_signals_standalone.cc
----------------
This goes into both static and shared, but must go into STATIC only. Don't remember details but it will fails on Android and Apple bots.
PTAL at D39827. Maybe just restore relevant parts of D39827.


================
Comment at: lib/ubsan/ubsan_init.h:34
 
+extern "C" SANITIZER_INTERFACE_ATTRIBUTE void __ubsan_init();
+
----------------
I am not sure that we need this in API, I'd prefer D39827 approach.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42389