[PATCH] D42379: [DAGCombiner] Bail out if vector size is not a multiple

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 22 08:32:26 PST 2018


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15191
 
+      // Bail out if the vector size is not a multiple of the scalar size.
+      if (VT.getSizeInBits() % SclTy.getSizeInBits())
----------------
"Bail out if the output vector size is not a multiple of the input vector size."

Shouldn't this be pulled out to near the top of the method?

FoldCONCAT_VECTORS actually treats this as an assert - is there anyway that you can cause it to fire there?


https://reviews.llvm.org/D42379





More information about the llvm-commits mailing list