[PATCH] D41565: [Transforms] Support making mutable versions of new-format TBAA access tags

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 22 02:41:30 PST 2018


kosarev added inline comments.


================
Comment at: llvm/trunk/lib/IR/MDBuilder.cpp:236
+MDNode *MDBuilder::createMutableTBAAAccessTag(MDNode *Tag) {
+  MDNode *BaseType = cast<MDNode>(Tag->getOperand(1));
+  MDNode *AccessType = cast<MDNode>(Tag->getOperand(1));
----------------
apilipenko wrote:
> Typo getOperand(1) instead of getOperand(0). And the test doesn't catch this because in the test Base and Access types are always the same.
Prepared a fix in D42364. Thanks for catching!


Repository:
  rL LLVM

https://reviews.llvm.org/D41565





More information about the llvm-commits mailing list