[PATCH] D41818: [AArch64][SVE] Asm: Predicate patterns

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:528
+    int64_t Val = MCE->getValue();
+    return (Val >= 0 && Val < 32);
+  }
----------------
no brackets needed.


================
Comment at: lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp:1350
+  else
+    O << '#' << formatImm(Val);
+}
----------------
IIUC this case happens if we want to print a pattern that is not in lookupSVEPREDPATByEncoding, right? Could we use an assert here, as I think this case should not happen if we do everything correctly?


https://reviews.llvm.org/D41818