[PATCH] D40849: CodeGen: support an extension to pass linker options on ELF

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd marked 8 inline comments as done.
compnerd added inline comments.


================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:99
+    auto *S =
+        C.getELFSection(".linker-options", ELF::SHT_PROGBITS, ELF::SHF_EXCLUDE);
+
----------------
jhenderson wrote:
> It would be good to add a comment documenting the section format (and purpose?) here, even though it is simple.
Given that none of the other file formats document the format here, I think that it is better documented in the linker or in the separate documentation (we do cover LLVM extensions).  I've done the latter.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:4091
+      StringRef Value = StringRef(reinterpret_cast<const char *>(P) + Key.size() + 1);
+
+      W.printString(llvm::StringSwitch<StringRef>(Key)
----------------
jhenderson wrote:
> clang-format?
Dunno how that happened.


Repository:
  rL LLVM

https://reviews.llvm.org/D40849