[PATCH] D42337: [Dominators] Introduce DomTree verification levels

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 20 13:52:11 PST 2018


kuhar added a comment.

@dberlin:

> I assume if we ever bothered to make the verification O(N) again using better algorithms, we'd go back to one level of verification?

I think it's very unlikely that someone will implement this in the foreseeable future. As far as I understand, this would disallow to perform any manual updates and require extra data to be sorted in the tree and the tree nodes.
But if someone implements this, it would be best to go back one verification level. And if it tells us the tree is incorrect, we could run the current full verification to get a descriptive error message telling us what exactly went wrong.


Repository:
  rL LLVM

https://reviews.llvm.org/D42337





More information about the llvm-commits mailing list