[PATCH] D42324: [WebAssembly] Remove --emit-relocs

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 19 17:09:57 PST 2018


ncw accepted this revision.
ncw added a comment.
This revision is now accepted and ready to land.

@ruiu  some background. We've been discussing whether there should be a genuine difference between relocatable and non-relocatable Wasm objects. Or to put it another way, if you run LLD on a single object file, should anything really change? Maybe a few bits and pieces in the headers, but the actual body should be basically "stable", maybe stripping some dead functions,.

At the moment, `--relocatable` output really is quite different to normal output, in that it creates Wasm imports+exports for everything, whereas normal LLD output doesn't export local functions for example.

Hence `--emit-relocs` doesn't really work, you can't just "emit the relocs", since without having the imports/exports there's nothing to relocate against. You can't emit the relocs unless you're writing out a whole different object file.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42324





More information about the llvm-commits mailing list