[PATCH] D42201: CodeGen: handle llvm.used properly for COFF

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 19 14:11:00 PST 2018


smeenai added a comment.

Patch is missing context.



================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1459
+              cast<GlobalValue>(Op->stripPointerCastsNoFollowAliases());
+          if (GV->hasInternalLinkage())
+            continue;
----------------
Add a comment about why internal symbols are ignored?


Repository:
  rL LLVM

https://reviews.llvm.org/D42201





More information about the llvm-commits mailing list