[PATCH] D42306: [WebAssembly] Symbol changes #4d: export import flags, LLD only

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: wasm/Writer.cpp:389
   std::vector<std::pair<StringRef, uint32_t>> SymbolInfo;
-  for (const WasmExportEntry &E : ExportedSymbols) {
+  auto addSymInfo = [&](const Symbol *Sym, StringRef ExternalName) {
     uint32_t Flags =
----------------
ncw wrote:
> sbc100 wrote:
> > I think this should follow the CamelCase convention for local variables (at least that is what others seems to do in lld).
> Oops, I renamed it following some code I saw elsewhere. I checked the LLVM style guide and it didn't say what to do for lambdas - are they lowercase as functions, or uppercase as variables?
> 
> I see about 50/50 looking at the first 20 grep results for `\[&\]`, so I guess it doesn't matter.
In ELF and COFF directories I only see the CamelCase style, and I think we should follow them.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42306