[PATCH] D42286: [libfuzzer] Don't try to build tests with the just built compiler unless it's usable.

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 19 13:17:23 PST 2018


bogner added a comment.

In https://reviews.llvm.org/D42286#982281, @phosek wrote:

> In that case, I think we should modify `add_custom_libcxx` and add a new argument `USE_TEST_COMPILER`, if not set it should use the host compiler (i.e. `CMAKE_C_COMPILER` and `CMAKE_CXX_COMPILER`). @vitalybuka WDYT?


Running libFuzzer's tests with the host compiler is a very different thing than running libFuzzer's tests with the just built compiler. I'm pretty sure using CMAKE_C_COMPILER for the tests will more or less just test the fuzzer and sanitizers from your host system, which really isn't useful for testing that the libFuzzer you built works.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42286





More information about the llvm-commits mailing list