[PATCH] D42306: [WebAssembly] Symbol changes #4d: export import flags, LLD only

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 19 12:38:27 PST 2018


sbc100 added inline comments.


================
Comment at: wasm/Writer.cpp:389
   std::vector<std::pair<StringRef, uint32_t>> SymbolInfo;
-  for (const WasmExportEntry &E : ExportedSymbols) {
+  auto addSymInfo = [&](const Symbol *Sym, StringRef ExternalName) {
     uint32_t Flags =
----------------
I think this should follow the CamelCase convention for local variables (at least that is what others seems to do in lld).


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42306





More information about the llvm-commits mailing list