[PATCH] D42263: [ARM] Fix perf regression in compare optimization.

Joel Galenson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 19 09:18:06 PST 2018


jgalenson added a comment.

Thanks.



================
Comment at: lib/Target/ARM/ARMBaseInstrInfo.cpp:2766
     if (I == B)
       // The 'and' is below the comparison instruction.
+      break;
----------------
efriedma wrote:
> Please fix this comment; there is no 'and', and instructions after the comparison are irrelevant.
For what it's worth, I believe the 'and' refers to the block at the beginning of the function, which can set MI to be equal to an 'and'.  But I agree that this comment is confusing, so I'll remove it.


https://reviews.llvm.org/D42263





More information about the llvm-commits mailing list