[PATCH] D41297: [ThinLTO] Implement summary visualizer

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 19 05:23:21 PST 2018


evgeny777 added inline comments.


================
Comment at: lib/IR/ModuleSummaryIndex.cpp:300
+    for (auto DstMod : ModList)
+      if (DstMod != E.SrcMod)
+        DrawEdge("  ", E.SrcMod, E.Src, DstMod, E.Dst, E.Hotness);
----------------
tejohnson wrote:
> Since these are cross module edges, when would these be equal?
The edge representing call or ref is drawn to every module target symbol is defined. When target is a linkonce symbol there can be multiple edges representing a single call or ref, both intra-module and cross-module. As we've already drawn all intra-module edges before we skip it here.


https://reviews.llvm.org/D41297





More information about the llvm-commits mailing list