[PATCH] D42284: [WebAssembly] MC: Start table at offset 1 rather than 0

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 19 01:11:28 PST 2018


ncw accepted this revision.
ncw added a comment.
This revision is now accepted and ready to land.

I can't see that anything would break by landing this and https://reviews.llvm.org/D42285 first.

There are some other changes in https://reviews.llvm.org/D42095 as well, because even with this offset-by-one change, the indexes written out by Clang still don't match the indexes LLD would write out for the same Symbols (for weak and aliased functions, of course!). But, the rest of #3 (https://reviews.llvm.org/D42095) definitely can't land before #2. Until the actual symbol indexes are being written out for the table relocations (#2), we can't alter the ELEM section to use exactly the same rules in Clang as it does in LLD.


Repository:
  rL LLVM

https://reviews.llvm.org/D42284





More information about the llvm-commits mailing list