[PATCH] D42105: [WebAssembly] Symbol changes #4: export relocatable, LLD only

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/trunk/wasm/Writer.cpp:67
+struct WasmExportEntry {
+  const Symbol *Symbol;
+  StringRef FieldName; // may not match the Symbol name
----------------
inglorion wrote:
> gcc seems unhappy with this declaration. It complains:
> 
>     llvm/tools/lld/wasm/Writer.cpp:67:17: error: declaration of ‘const lld::wasm::Symbol* {anonymous}::WasmExportEntry::Symbol’ [-fpermissive]
>        const Symbol *Symbol;
>                  ^
>     In file included from llvm/tools/lld/wasm/Config.h:17:0,
>                      from llvm/tools/lld/wasm/Writer.cpp:13:
>     llvm/tools/lld/wasm/Symbols.h:27:7: error: changes meaning of ‘Symbol’ from ‘class lld::wasm::Symbol’ [-fpermissive]
>      class Symbol {
>            ^
> 
> I have put up D42278 to rename the field and stop the naming collision.
Thanks!  I already had a local version ready to go so I'll just push that if thats OK?


Repository:
  rL LLVM

https://reviews.llvm.org/D42105