[PATCH] D42214: libcxx: Move Windows threading support into a .cpp file.

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai requested changes to this revision.
smeenai added a comment.
This revision now requires changes to proceed.

This prevents inlining, which might not be great. I'd be happier if we kept everything in the header but just forward declared whatever we needed from the Windows headers rather than actually including them (I've been meaning to do that for a while, just haven't gotten the chance to work on it yet).

Also, IIRC, a CRITICAL_SECTION is actually a 40-byte sized struct, so replacing `CRITICAL_SECTION` with `void *` is gonna cause issues.


https://reviews.llvm.org/D42214