[PATCH] D41903: [ValueLattice] Use union to shave off ptr size bytes from elements.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks for having a look!



================
Comment at: include/llvm/Analysis/ValueLattice.h:86
+    case constantrange:
+      new (&Range) ConstantRange(1, true);
+      Range = Other.Range;
----------------
reames wrote:
> Might make sense to add a ConstantRange copy constructor or move constructor.  You have this idiom in a couple of places.
ConstantRange already has a copy constructor and I updated the code to use ìt: `new (&Range) ConstantRange(Other.Range);`. I hope that I understood what you meant correctly :)


https://reviews.llvm.org/D41903