[PATCH] D42105: [WebAssembly] Symbol changes #4: export relocatable, LLD only

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 15:26:56 PST 2018


sbc100 added inline comments.


================
Comment at: wasm/Writer.cpp:390
+  std::vector<std::pair<StringRef, uint32_t>> SymbolInfo;
+  for (const WasmExportEntry &E : ExportedSymbols) {
+    uint32_t Flags =
----------------
Don't we want to iterate through all symbols here, not just the exported ones?   This can be a followup change I think.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42105





More information about the llvm-commits mailing list