[PATCH] D42244: [globalisel] Introduce LegalityQuery to better encapsulate the legalizer decisions. NFC.

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 15:07:45 PST 2018


dsanders added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/LegalizerInfo.h:56
+  unsigned Opcode;
+  ArrayRef<LLT> Types;
+
----------------
rovka wrote:
> Is it really a good idea to store an ArrayRef in the long run?
This object is only needed for the duration of a single call to getAction() so there shouldn't be any problems with LegalityQuery::Types outliving the array used to initialize it.


https://reviews.llvm.org/D42244





More information about the llvm-commits mailing list