[PATCH] D42055: Fallback option for colorized output when terminfo isn't available

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

I'd like it better if you just removed the "#ifdef HAVE_TERMINFO" branch of code entirely, along the cmake support for causing it to be defined and adding TERMINFO_LIBS to llvm. (lldb still looks like it uses it, so can't just remove everything related to terminfo from the cmake support files)

Both GCC and Git simply use the TERM is set and != "dumb" check, and never touch curses. If it's good enough for them, it's good enough for llvm too, and we don't need to extra complexity and dependencies. Also, the hacks in this code are ugly (writing our own function signatures for these functions instead of using a proper #include!).


Repository:
  rL LLVM

https://reviews.llvm.org/D42055