[PATCH] D42250: [NFC] Modernize code style and comments in DwarfAccelTable

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 10:48:31 PST 2018


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Minor nitpicks, general direction is fine of course.



================
Comment at: lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp:210
+/// bucket. For the string case emit the dies and the various offsets.
+/// Terminate each HashData bucket with 0.
 void DwarfAccelTable::EmitData(AsmPrinter *Asm, DwarfDebug *D) {
----------------
I think these comments are supposed to go into the class definition.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfAccelTable.h:90
+    // The total number of unique hash values and hash data offsets in this
+    // table.
+    uint32_t HashesCount = 0;
----------------
///


Repository:
  rL LLVM

https://reviews.llvm.org/D42250





More information about the llvm-commits mailing list