[PATCH] D42237: [WebAssembly] Symbol changes #4b: export stack-pointer, LLD only

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 10:27:43 PST 2018


sbc100 added a comment.

In https://reviews.llvm.org/D42237#980509, @ncw wrote:

> Ah! I thought this might be contentious. I guess the `--emit-relocs` output isn't critical for anything at the moment.


Indeed, I'm not even sure we want to continue support it as a separate options to '-r/--relocatable' (of which --emit-relocs) is a subset.   I'm tempted to rip and out and replace `Config->EmitRelocs` with `Config->Relocatable`, at least until we can come up with a reasonable use case (I suppose we use it in tests... but that isn't really a good enough motivation).

In any case this change is need for the `--relocatable` case.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42237





More information about the llvm-commits mailing list