[PATCH] D40900: [Sanitizers, test] Fix sanitizer tests on Solaris (PR 33274)

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

In https://reviews.llvm.org/D40900#978241, @krytarowski wrote:

> @ro For your interest, just in case that it's in the scope of your interest:
>  there is a work towards merging your work with Illumos and ship in pkgsrc.
>
> http://mail-index.netbsd.org/tech-pkg/2018/01/16/msg019322.html


That's great news: I saw something like this flying by on Twitter.  There will certainly be some
areas where Solaris and Illumos differ, but the majority will be the same.

> There are also patches generated locally for SmartOS... it would be great to merge them
>  instead of keeping in downstream branches.

Absolutely: keeping large patch sets local for a long time creates an incredible amount of
work for everyone.  I was totally horrified when I saw the old Solaris userland llvm 3.9 patches:
nobody would have been able to get those upstream.

In my case, getting the sanitizer port upstream was the only way to get it into gcc at all :-)



================
Comment at: test/asan/TestCases/alloca_constant_size.cc:14
 # define alloca _alloca
-#elif defined(__FreeBSD__) || defined(__NetBSD__)
-#include <stdlib.h>
-#else
+
+#if defined(__sun__) && defined(__svr4__)
----------------
krytarowski wrote:
> I've added `#endif` here as a hotfix.
Thanks so much for doing this: this one time I thought I could
things right without a quick check-all.  Certainly the last time
I tried that!


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D40900