[PATCH] D42204: Make the bloom filter a bit larger.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 00:55:31 PST 2018


grimar added a comment.

I also observed that increasing of filter size gives boost.
And wiki says:
"A Bloom filter with 1 % error and an optimal value of k, in contrast, requires only about 9.6 bits per element, regardless of the size of the elements. This advantage comes partly from its compactness, inherited from arrays, and partly from its probabilistic nature. The 1 % false-positive rate can be reduced by a factor of ten by adding only about 4.8 bits per element."
So I think value = 12 is probably should be fine balance.

Patch increases size of output though and orthogonal to other possible optimizations (like attemps to tweak Shift2). Are we ok to increase output size atm ?


https://reviews.llvm.org/D42204





More information about the llvm-commits mailing list