[PATCH] D41915: [lldCOFF] Print detailed timing information with /VERBOSE

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 20:28:17 PST 2018


Well, I don't think that's inconsistent, but showing only the total at
bottom seems inconsistent, because timers are organized as a tree. When we
show some tree, usually the root is not shown in a special way. Think of
the file tree in Windows Explorer for example. The root is at the beginning
just like other sub-trees. It's also different from what we usually do with
pen and paper because it's a tree.

 47
+23
  17
  6
----
 70

The following seems much more natural to me.

70
 |- 47
 |- 23
     |- 17
     |- 6


On Wed, Jan 17, 2018 at 5:55 PM, Zachary Turner <zturner at google.com> wrote:

> Putting the total at the top is inconsistent with every other profiling
> output i can find from similar tools, and also with normal pen and paper
> math which would be written
>
> ```
> 47
> +23
> —-
> 70
> ```
>
> Can we leave it at the bottom?
>
> On Wed, Jan 17, 2018 at 1:07 PM Rui Ueyama via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> ruiu added a comment.
>>
>> It seems it is still showing the total timer at the end. Can you fix it?
>>
>>
>> Repository:
>>   rLLD LLVM Linker
>>
>> https://reviews.llvm.org/D41915
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180117/60ca89f0/attachment.html>


More information about the llvm-commits mailing list