[PATCH] D42006: AArch64: Omit callframe setup/destroy when not necessary

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 16:08:00 PST 2018


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

In general the idea makes sense: adjusting the stack by zero bytes is a no-op, so we don't need to mark it with a MachineInstr.  I'm a little worried we're going to trip over some edge case where we depend on the call frame opcodes for some other reason, but I can't think of anything specific, so I guess we'll see.  Please make sure you've run some basic correctness tests before you merge.


Repository:
  rL LLVM

https://reviews.llvm.org/D42006





More information about the llvm-commits mailing list